Open
Conversation
Added UM order function Added UM open orders function.
Added UM trades function.
Added the usdm_um new functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for a great package. I was curious if the usdm features would work in the coinm futures. Just changing the api address makes it possible to work with coin-m api as well.
I am new to package building and github, so I apologize in advance if I have taken a misstep here.
In sending an order in one-way mode, the positionSide argument should be "BOTH". Otherwise, it keeps getting an error code 4061 POSITION_SIDE_NOT_MATCH. In the latest commit, I added the "BOTH" argument to the binance.R. As far as I checked, it works the same way in the USDM futures. So, this commit (28a5d12) may be beneficial in the one-way mode new order in USDM API as well.
The other commits are api address changes and should be dismissed; however, I couldn't delete them and only send the last commit.